Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Losses (and Penalties) modules or group under Objectives module #118

Closed
8 tasks done
pat-alt opened this issue Feb 22, 2023 · 1 comment · Fixed by #126
Closed
8 tasks done

Add Losses (and Penalties) modules or group under Objectives module #118

pat-alt opened this issue Feb 22, 2023 · 1 comment · Fixed by #126
Assignees
Labels
CCE 💯 enhancement New feature or request

Comments

@pat-alt
Copy link
Member

pat-alt commented Feb 22, 2023

Instead of relying on Flux.Losses, in the end it seems more appropriate to have a separate module for custom loss functions. Similarly, it may be useful to have a designated module for penalties. Not sure yet, but perhaps the best option is to group both under an Objective module.

  • Decide on architecture
  • Implement custom losses
  • Move existing penalty methods
  • Add an @objective macro for composable generators
  • Be explicit about convergence type: threshold, max_iter or gradient.
  • Add additional macros for composable generators.
  • Update docs.
  • Augment tests.
@pat-alt pat-alt added the enhancement New feature or request label Feb 22, 2023
@pat-alt pat-alt self-assigned this Feb 22, 2023
@pat-alt
Copy link
Member Author

pat-alt commented Mar 11, 2023

Some thoughts after completing #121

  • It may be worth linking penalties and evaluation measures, since the two are in many case related: L1/L2-norm for example is used both as a penalty and evaluation measure.
  • Should every penalty be usable as an evaluation measure? Both take a ce::CounterfactualExplanation as their main argument ... Edit: No, doesn't work for CCE, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCE 💯 enhancement New feature or request
Projects
None yet
1 participant