Fix set_default_connection_limit not being respected #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With all the default global connection pool shuffling that has happened, we missed making sure `set_default_connection_limit!` was still being respected. It was updating the global connection limit ref, but the global pools were still stuck with whatever their values were when first initialized. This PR reinitializes the global connection pools when the default connection pool limit is changed.
Sacha0
reviewed
May 19, 2023
test/client.jl
Outdated
| @@ -13,6 +13,7 @@ using InteractiveUtils: @which | |||
|
|
|||
| # test we can adjust default_connection_limit | |||
| HTTP.set_default_connection_limit!(12) | |||
| @test HTTP.Connections.TCP_POOL[].max == 12 | |||
There was a problem hiding this comment.
Possibly paranoid, but might save us at some point: Perhaps test the same expectation of the other pools?
Sacha0
approved these changes
May 19, 2023
nickrobinson251
approved these changes
May 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #1053 +/- ##
==========================================
+ Coverage 85.25% 85.27% +0.02%
==========================================
Files 32 32
Lines 3031 3036 +5
==========================================
+ Hits 2584 2589 +5
Misses 447 447
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Nick Robinson <npr251@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With all the default global connection pool shuffling that has happened, we missed making sure
set_default_connection_limit!was still being respected. It was updating the global connection limit ref, but the global pools were still stuck with whatever their values were when first initialized.This PR reinitializes the global connection pools when the default connection pool limit is changed.