Remove readuntil type piracy
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1083 +/- ##
==========================================
- Coverage 82.33% 82.30% -0.03%
==========================================
Files 32 32
Lines 3040 3041 +1
==========================================
Hits 2503 2503
- Misses 537 538 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
approved these changes
Aug 2, 2023
|
It looks like the invalidations test failure is unrelated? |
|
All looks good; thanks @mortenpi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that the
readuntilfunction used by HTTP is owned by theIOExtrasmodule, and so that it would be safe to add the currently type-pirated method taking anIOBuffer. Towards #1021.I am not entirely sure what the best approach here is in terms of code maintainability though. Currently, I opted to keep the name the same (
readuntil) and export it fromIOExtras, so any module doingusing IOExtrasand using an unqualifiedreaduntilwill error (as the same name is exported fromBase).