Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugged code? #800

Closed
louisponet opened this issue Feb 9, 2022 · 2 comments · Fixed by #824
Closed

Bugged code? #800

louisponet opened this issue Feb 9, 2022 · 2 comments · Fixed by #824

Comments

@louisponet
Copy link

While browsing through the code to investigate some invalidations @timholy and I came across this part:

HTTP.jl/src/IODebug.jl

Lines 15 to 26 in 46687c8

struct IODebug{T <: IO} <: IO
io::T
log::Vector{Tuple{String,String}}
end
IODebug(io::T) where T <: IO = IODebug{T}(io, [])
logwrite(iod::IODebug, f, x) = push!(iod.log, ("➡️ ", f, x))
logread(iod::IODebug, f, x) = push!(iod.log, ("⬅️ ", f, x))
end

Does that code ever get used, and is it valid?
It is sadly not involved with the invalidations though.

Cheers

@fredrikekre
Copy link
Member

Basically duplicate of #712

@louisponet
Copy link
Author

Well, the invalidations part yes, the part about this branch not being executable I don't see being mentioned before. Of course if the debug code will be taken out then this solves itself :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants