Ensure a Request accounts correctly for isredirect/retryable #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new functionality where a response_stream will only be written to on the "final" request in the case of redirects/retries, we failed to account for the case when the user specifically requests no redirects/retries, so the behavior involved NOT redirecting/retrying, yet we weren't writing the response body to the response_stream because the Request was otherwise deemed redirectable/retryable. This PR fixes it by incorporating the values of the redirect/redirect_limit/retry/retry_limit keyword args into the computation of isredirect/retryable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new functionality where a response_stream will only be written to
on the "final" request in the case of redirects/retries, we failed to account
for the case when the user specifically requests no redirects/retries,
so the behavior involved NOT redirecting/retrying, yet we weren't writing
the response body to the response_stream because the Request was otherwise
deemed redirectable/retryable. This PR fixes it by incorporating the values
of the redirect/redirect_limit/retry/retry_limit keyword args into the
computation of isredirect/retryable.