Store the original registered route path when Router matches #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a common feature of other router implementations, sometimes referred to as "reverse routing". We don't go the full way in allowing you to do `getregisteredroute(r::Router, url)`, but we could do that eventually. For now, it's at least very useful to store the registered route that was matched during request handling.
fredrikekre
reviewed
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common feature of other router implementations, sometimes referred
to as "reverse routing". We don't go the full way in allowing you to do
getregisteredroute(r::Router, url), but we could do that eventually. For now,it's at least very useful to store the registered route that was matched
during request handling.