Cleanup header initialization to avoid excessive copies #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #991 +/- ##
==========================================
+ Coverage 82.56% 82.75% +0.19%
==========================================
Files 37 37
Lines 3046 3051 +5
==========================================
+ Hits 2515 2525 +10
+ Misses 531 526 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nickrobinson251
approved these changes
Jan 11, 2023
| @@ -410,7 +410,7 @@ end | |||
| function getconnection(::Type{TCPSocket}, | |||
| host::AbstractString, | |||
| port::AbstractString; | |||
| keepalive::Bool=false, | |||
| keepalive::Bool=true, | |||
There was a problem hiding this comment.
can you add a comment on why this default to true?
quinnj
commented
Jan 11, 2023
Set keepalive to true by default for tcp layer. Fix bug where both StatusCodes & Messages were exporting `statustext`.
quinnj
force-pushed
the
jq-various-fixes
branch
from
0627dda
to
3095bb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set keepalive to true by default for tcp layer.
Fix bug where both StatusCodes & Messages were exporting
statustext.