Nowutcstuff

[IainNZ]

Very confused...

[IainNZ]

@quinnj any ideas why this is necessary? I thought the if at the top should do everything required for Dates stuff?

[coveralls]

Coverage increased (+0.38%) when pulling f8a37bb on nowutcstuff into 6f25a1d on master.

[IainNZ]

@WestleyArgentum maybe you know, you were the one who changed this last (although it wasn't tested)

[coveralls]

Coverage increased (+0.2%) when pulling f8a37bb on nowutcstuff into 6f25a1d on master.

[IainNZ]

I'm merging for now, but still curious if this is correct.

[quinnj]

Sorry for not responding quicker. So I think the issue is that Dates.utcnow() was actually removed from 0.3 compatible version (it only ever existed for like, a day, but that's how things go, right?). Was there a 0.3/0.4 compatibility issue with this when just using Dates.now(Dates.UTC)?

[IainNZ]

Yes there is, at least on Travis.

• The "fix now(UTC)" commit changed it to Dates.nowutc() which was OK on 0.3, and failed 0.4.
• The "old behaviour" commit changed it to Dates.now(Dates.UTC) which failed on 0.3, but worked on 0.4
• The final commit put it in an if statement...

I'm very confused about what should be happening/what is correct.

[WestleyArgentum]

Sorry! I've been out of town!

Back when I was changing things Dates.nowutc() had just been added to Dates and there was a discussion here: JuliaLang/julia@5999f53 about whether it should be changed. The consensus was to go with Dates.now(Dates.UTC), and I totally dropped the ball changing things once that had been merged.

But I'm a little confused as well, I believe that both 0.3 and 0.4 should both be using the new Dates.now(Dates.UTC) interface. Maybe something didn't get merged back into Dates.jl? Or a new version needs to be tagged? Can poke around in an hour or so

[WestleyArgentum]

@quinnj It looks like the more recent changes from julia/base/dates need to be pulled into Dates.jl. I'm not 100% sure the easiest way to do this, but it would be nice to keep the same history... so maybe that means making a copy of the julia git repo, stripping everything not ./dates, and then merging that into Dates.jl? I can try sometime soon if no one knows a better way

[quinnj]

Yeah, I need to do another sync. I'll try to do it this afternoon.

[quinnj]

Ok, synced Dates for 0.3 and tagged new version.