Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text/julia MIME for .jl? #4

Closed
fonsp opened this issue Mar 25, 2022 · 3 comments · Fixed by #7
Closed

Add text/julia MIME for .jl? #4

fonsp opened this issue Mar 25, 2022 · 3 comments · Fixed by #7

Comments

@fonsp
Copy link
Member

fonsp commented Mar 25, 2022

Some info in JuliaLang/julia#26947

The MIME itself is not so important, but it is important to set charset=utf8 when serving julia files.

@tlienart
Copy link
Collaborator

can be done by adjusting
https://github.com/fonsp/MIMEs.jl/blob/784c53aaf8f03cd9c76597c0b8cd0be88e7155a3/mimedb/update.jl#L43-L44

Note: I think the logic with skip can be removed, so that the output file (mimedb.jlon) is always overwritten.

@fonsp
Copy link
Member Author

fonsp commented Mar 25, 2022

Thanks! Do you think it is a good idea to add the julia MIME?

@tlienart
Copy link
Collaborator

I don't see what harm it would do! Getting a more specific mime would seem to me like a good thing and they should implement fallbacks anyway since there's so many weird and super specific mimes :-)

@fonsp fonsp linked a pull request Mar 25, 2022 that will close this issue
@fonsp fonsp closed this as completed in #7 Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants