Handle multipleOf overflow
#746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 17 17
Lines 2664 2668 +4
Branches 310 310
=======================================
+ Hits 2558 2562 +4
Misses 87 87
Partials 19 19
Continue to review full report at Codecov.
|
Zac-HD
force-pushed
the
multipleOf-overflow
branch
from
1436b56
to
46db62a
Compare
|
O the naïveté of our youth -- we bid you farewell... Thanks :)! |
|
Happy to help! Guess I'll have to update https://hypofuzz.com/example-dashboard/failing.html, but that's OK... I might just add a link to the issue 😉 |
|
Oh. Fun. That looks nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #743, by falling back to use of
Fractions on float overflow.This passes both the required and the optional test from json-schema-org/JSON-Schema-Test-Suite#438