Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific support for version implementations #2

Open
Julian opened this issue Nov 7, 2019 · 2 comments
Open

Add specific support for version implementations #2

Julian opened this issue Nov 7, 2019 · 2 comments

Comments

@Julian
Copy link
Owner

Julian commented Nov 7, 2019

It feels like there may be what to do specifically with e.g. incremental.Version, packaging.Version, semver.Version, and the 8000 other version implementations.

Maybe we only care about some of them, especially since "do something" potentially just means "know how to convert them back to strings", but adding this at least to investigate.

@adiroiban
Copy link
Contributor

adiroiban commented Dec 5, 2020

I hope we can continue to use regret with just text strings :)

I guess that more specific version implementation (other than string) is required for comparing versions.

If we need to print the version the message just str(version)

@Julian
Copy link
Owner Author

Julian commented Dec 5, 2020

Is "have" there meant to be "hope"? My thought was yeah definitely it should always be possible to keep using text strings, but that if you had a more sophisticated object, as you said, for comparisons perhaps, that that'd be the reason to support something else.

But yeah comments definitely welcome if you have ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants