Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to pass custom parser implementation to Planner #211

Closed
wants to merge 2 commits into from
Closed

Add a way to pass custom parser implementation to Planner #211

wants to merge 2 commits into from

Conversation

vkorukanti
Copy link
Contributor

Hi Julian,

This is the change for providing a custom parser implementation to Planner through Frameworks. As discussed sometime back on optiq group:

  1. Moved the SqlParserImpl methods used in SqlParser into SqlAbstractParserImpl. Now SqlParser only interacts with the SqlAbstractParserImpl provided methods.
  2. Provided a parser factory interface and implementation for Optiq's standard parser.

Please take a look at it and let me know if there are any changes needed.

Thanks
Venki

julianhyde
julianhyde reviewed Mar 26, 2014
View reviewed changes
core/src/main/java/org/eigenbase/sql/parser/SqlParser.java

import org.eigenbase.sql.*;
import org.eigenbase.sql.parser.SqlAbstractParserImpl.Metadata;
import org.eigenbase.sql.parser.impl.*;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import

@julianhyde
Copy link
Owner

Rebased as 1b3068f.

@julianhyde julianhyde closed this Mar 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@vkorukanti @julianhyde