[Feature Request] ICMP

[washley]

Support for reading/writing ICMP would be helpful. There's an opportunity after that for helper methods to generate common ICMP packets, for example fragmentation needed and time exceeded.

[man0lis]

+1
I would love to see this. Currently I have to use other packet building crates in combination with etherparse to create ICMP packets. It would be nice to have the same ease of use I get from etherparse when generating ICMP packets.

[JulianSchmid]

+1
I would love to see this. Currently I have to use other packet building crates in combination with etherparse to create ICMP packets. It would be nice to have the same ease of use I get from etherparse when generating ICMP packets.

Hi,

I am thinking about it. What are the types of ICMP packets that would be most important for you?

Greets
Julian

[man0lis]

Currently EchoRequest and EchoReply would be sufficient for me.

[washley]

Destination Unreachable is the most interesting one for me.

[johalun]

Came here looking for ICMP as well :)

[vkrasnov]

Hi, I would like to see ICMP support as well.

I can also implement and open a PR if you are willing to accept.

[robs-zeynet]

@JulianSchmid I'm looking for ICMP support as well... and am happy to try to implement it. If I submitted a patch/pull request, would you be willing to accept it (assuming the code wasn't too horrible)?

I was thinking of adding ICMP as another type of TransportHeader so it could be easily matched against Tcp/Udp/etc.- thoughts? Please let me know and thanks.

[JulianSchmid]

@robs-zeynet Sounds good, but I cannot guarantee that I will find time right away for a code review & merges. I have a bit of time the next few weeks and after that I will have to find time on the weekends. Which was difficult to find in 2020. But next year will (hopefully) be less stressful.

In the following weeks I will try to finally finish up #13 after which I can finally rebase and merge #11 .

[cemeyer]

I am thinking about it. What are the types of ICMP packets that would be most important for you?

Time Exceeded is useful as well (ICMP notification of reaching the TTL limit).