-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveness probes #9
Comments
hey, thanks ! i am not sure if that's the role of the library to do that when you create your Bentocache instance, you must pass your and also, there are drivers for which it wouldn't make sense to have this, like filesystem and in-memory. let me know what you think |
I agree with you that if a library like bentocache provides one with the ability to supply his own (redis or whatsoever) instances there should be no need to implement healthchecks. Still I think that given the aim of bentocache, a built in healthcheck would be nice! Moreover, I don't see this capability with redis' bus driver, as in the constructor you can only provide ioredis options. As for memory or fs drivers, I still think that a healthcheck can [1] [2] be implemented, even if that may not make sense for common workloads. Also, testing won't be trivial. With that being said, I still think it would be a nice feature but perhaps not as valuable as it is to me for other users. |
Hi and thank you for this much needed library.
Have you considered, or are you planning to add, a way to drivers are able to communicate properly?
I'm thinking about exposing a function to
ping
redis orselect 1
a database.It would be great to have such functionality available on the BentoCache instance, to be called when needed or exposed by an http route.
The text was updated successfully, but these errors were encountered: