feat: allow to pass custom locale for faker

Julien-R44 · Sep 20, 2022 · eba90d0 · eba90d0
1 parent ff174c7
commit eba90d0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/bin/test.ts b/bin/test.ts
@@ -26,7 +26,7 @@ configure({
     files: ['tests/**/*.spec.ts'],
     plugins: [
       database({ database: connectionConfig }),
-      factorio({ database: connectionConfig }),
+      factorio({ database: connectionConfig, locale: 'fr' }),
       expect(),
     ],
     reporters: [specReporter({ stackLinesCount: 2 })],

diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts
@@ -1,4 +1,6 @@
 import knex from 'knex'
+import { faker } from '@faker-js/faker'
+import type { UsableLocale } from '@faker-js/faker'
 import type { Knex } from 'knex'
 import type { FactorioConfig } from './contracts'
 
@@ -14,7 +16,9 @@ export const factorioConfig = {
  *
  * Returns a function that can be used to clean up the connection.
  */
-export const defineFactorioConfig = (options: FactorioConfig) => {
+export const defineFactorioConfig = (options: FactorioConfig & { locale?: UsableLocale }) => {
+  faker.locale = options.locale || faker.locale
+
   factorioConfig.knex = knex(options.database)
 
   return () => {

diff --git a/packages/japa-plugin/src/index.ts b/packages/japa-plugin/src/index.ts
@@ -1,9 +1,8 @@
 import { defineFactorioConfig } from '@julr/factorio'
-import type { Knex } from 'knex'
 import type { PluginFn } from '@japa/runner'
 
-export function factorio({ database }: { database: Knex.Config }): PluginFn {
-  const disconnect = defineFactorioConfig({ database })
+export function factorio(options: Parameters<typeof defineFactorioConfig>[0]): PluginFn {
+  const disconnect = defineFactorioConfig(options)
 
   return async function (config) {
     config.teardown.push(disconnect)