Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match system theme #47

Closed
gdude2002 opened this issue Aug 9, 2023 · 5 comments
Closed

Match system theme #47

gdude2002 opened this issue Aug 9, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@gdude2002
Copy link

Is your feature request related to a problem? Please describe.
As someone that primarily uses the light theme and has my system set up in light mode, it's a little jarring on my eyes when I open Spotify, and it's in dark mode by default.

Describe the solution you'd like
It'd be nice if this theme was able to make use of a media query (prefers-color-scheme) to preselect the light/dark theme by default, matching the system's configuration - if this is possible to do within Spotify's app container.

Describe alternatives you've considered
An alternative may be to provide a snippet or configuration option that switches the default theme to light mode instead of dark mode.

Thanks!

@gdude2002 gdude2002 added the enhancement New feature or request label Aug 9, 2023
@gdude2002
Copy link
Author

Oops, my mistake, I just noticed #38 - I'll go update that instead.

@JulienMaille
Copy link
Owner

Used to work until last update, Spotify broke it and there's nothing I can do

@gdude2002
Copy link
Author

Ah, that's unfortunate - in that case, given that the theme comes bundled with an extension, are there any plans to provide a way to change the default, or to split the theme into two (light and dark)?

@JulienMaille
Copy link
Owner

Actually try the patch: https://github.com/JulienMaille/spicetify-dynamic-theme/blob/main/patch-dark-mode.ps1
It worked on my system

@gdude2002
Copy link
Author

I can confirm that this works - thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants