Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Editor JS in his second version does not render i18n correctly #212

Open
SalahAdDin opened this issue Oct 14, 2022 · 1 comment
Open
Labels
bug Something isn't working

Comments

@SalahAdDin
Copy link

Environment

  • @editorjs/editorjs version: 2.25.0
  • react-editor-js version: 2.1.0

Describe

Passing i18n object for internationalization through the react-editor-js latest version:

Following the documentation, we pass both the direction and messages properties to i18n:

<EditorJS
          // data={JSON.parse(value)}
          // enableReInitialize={true}
          onReady={handleReady}
          onChange={handleChange}
          tools={{ ...requiredTools, ...customTools, ...customImageTool }}
          instanceRef={(instance) => setEditorInstance(instance)}
          i18n={getI18N(currentLanguage)}
        />

As you can see in the picture, the property is coming to the editor component, but it is rendering all messages in English yet.

Additionally, we have another bug:
Screen Shot 2022-10-14 at 00 10 27

We tested the same setup with react-editor-js version: 1.10.0 and it works fine.

Could it be possible the package is omitting this API too?

Thank you.

@SalahAdDin
Copy link
Author

@Jungwoo-An any thoughts on this problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant