#1 Fix: isOn Property Sets Incorrect State #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunichiT
added a commit
that referenced
this pull request
Dec 7, 2015
#1 Fix: isOn Property Sets Incorrect State
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Description
As the issue reported in #1, there was a bug of the incorrect position of the thumb when
isOnproperty is NO.The bug screenshot: The thumb's initial position should be OFF.
And fixed behavior is following:
The reason of this happening is the missing of the initial positioning function in
willMoveToSuperview.This PR fixes this bug and updates the pod version to 1.1.