Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Resolution Implementation #5

Closed
tprdk opened this issue Jan 31, 2022 · 2 comments
Closed

Super Resolution Implementation #5

tprdk opened this issue Jan 31, 2022 · 2 comments

Comments

@tprdk
Copy link

tprdk commented Jan 31, 2022

Hi, thanks for your great work.
I just check out your paper and it seem quite well on domain translation tasks and wanna try this work on super resolution task.
I tried to set one generator model up sampling size to 0 and another one's up sampling size 2. But it gives me incorrect channel size error. Can you give me any advice about how can i implement this?

@JunlinHan
Copy link
Owner

Hi tprdk, thanks for your issues.
The super-res network is often different from the image-to-image translation network. I recommend that you use the super-res network as the generator.

If you want to modify this one, you might need to carefully check the shape of output tensors in each CNN layer. I guess the case you encounter is due to input_nc (int) and output_nc (int) do not align between 2 generators. Also, changing the up sampling size may affect h/w dimension. You might need to check this.

@tprdk
Copy link
Author

tprdk commented Feb 1, 2022

Thanks for your quick reply.
I will try to implement this as you suggest. Really appreciate for your detailed answer.

@tprdk tprdk closed this as completed Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants