Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EADDRINUSE error code wrong for macOS in precompile.jl #71

Closed
ecuk opened this issue Nov 14, 2016 · 1 comment
Closed

EADDRINUSE error code wrong for macOS in precompile.jl #71

ecuk opened this issue Nov 14, 2016 · 1 comment

Comments

@ecuk
Copy link

ecuk commented Nov 14, 2016

In precompile.jl there is a (new) piece of code that chooses a port for the mock server. It is hard-coded to look for an EADDRINUSE error number of -4091. On macOS, and perhaps other *nix systems, the error code returned is -48, not -4091. The comparison fails and the exception is simply rethrown instead of trying the next port.

It looks as if a comparison against Base.UV_EADDRINUSE instead of a hard-coded number would fix the problem.

@pfitzseb
Copy link
Member

Thanks for the note -- this should be fixed with ff7228d.

New version will hopefully be out soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants