Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect device_class for D230 doorbell battery sensor. #571

Closed
Spamfast opened this issue May 14, 2024 · 2 comments
Closed

Incorrect device_class for D230 doorbell battery sensor. #571

Spamfast opened this issue May 14, 2024 · 2 comments
Labels
Fixed Bug has been fixed.

Comments

@Spamfast
Copy link

Description

I have a Tapo D230 doorbell connected via an H200 hub. The integration is exposing all its attributes correctly except that the sensor.xxxx_battery battery level percentage is being given a device class of 'mdi:battery' and not 'battery' and so is not showing up in battery-filtered cards, automations etc. For now I've corrected it in my customization YAML file.

Reproduction Steps

  1. Install the Tapo app on Android device.
  2. Add the H200 hub.
  3. Add the D230 doorbell.
  4. Install Tapo: Cameras Control from HACS.
  5. Add the hub to the integration - doorbell auto-detected and configured.
  6. Check in Developer Tools->States -- device_class shows as 'mdi:battery'.

Expected behavior

The device class should be the string 'battery' not 'mdi:battery'.

If applicable, add error logs.

No response

Device Firmware

D230 1.1.14, H200 1.3.1

Integration Version

5.4.18

Using stream component

Yes

Does camera work via official integrations?

Yes

Camera has all attributes filled out in developer tools

Yes

HASS Environment

Vanilla HAOS image on x86_64 PC.

Search for similar issues

Yes

Additional information

Core 2024.5.3, supervisor 2024.05.1, OS 12.3, frontent 20240501.1.

@Spamfast Spamfast changed the title Incorrect device_class for D230 doorbell. Incorrect device_class for D230 doorbell battery sensor. Jun 12, 2024
@Spamfast
Copy link
Author

Spamfast commented Jun 12, 2024

Problem is a one-liner in the TapoBatterySensor class constructor where it's setting the device_class argument instead of the icon argument in the base class constructor call.

I'll try to find time to clone, fix & pull request but I'm busy elsewhere so might not be soon.

@JurajNyiri
Copy link
Owner

@JurajNyiri JurajNyiri added the Fixed Bug has been fixed. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Bug has been fixed.
Projects
None yet
Development

No branches or pull requests

2 participants