BUG IN SETAVATAR

[OzzyHelix]

Please tick all applicable boxes.

• I am using Python 3.5 or higher (run python --version on the command line)
• I have followed the official guides to install the bot for my system
• I have updated my dependencies to the latest version using the appropriate update script

Which version are you using?

• The latest master version (1.9.7)
• The latest review version

What type of issue are you creating?

• Bug
• Feature request
• Question

---

Description of issue

a bug in the setavatar command
there was someone who's case was not reproducible
in particular module 'aiohttp' has no attribute 'Timeout'
in the setavatar command changing
this

        try:
            with aiohttp.Timeout(10):
                async with self.aiosession.get(thing) as res:
                    await self.user.edit(avatar=await res.read())

to this

        try:
            with async_timeout.timeout(10):
                async with self.aiosession.get(thing) as res:
                    await self.user.edit(avatar=await res.read())

will fix the problem
however it might not be a long term solution however it does make the link uploading work at the very least

Steps to reproduce

1. attempting to change the avatar from a link
   note: uploading images as an avatar doesn't work because of this bug

---

Log file

Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.
musicbot.log

[AleanaA]

I didn't test your solution, however 5 seconds in the aiohttp documentation, I found this, and made

    try:  
        timeout = aiohttp.ClientTimeout(total=10)  
        async with aiohttp.ClientSession(timeout=timeout):  
            async with self.aiosession.get(thing) as res:  
                await self.user.edit(avatar=await res.read())

Although this works, it led to

168118999337402368/Aleana#2643: !setavatar
[ERROR:bot] Exception in on_message
Traceback (most recent call last):
File "/mnt/secondary/aleana/test/MusicBot/musicbot/bot.py", line 2726, in on_message
response = await handler(**handler_kwargs)
File "/mnt/secondary/aleana/test/MusicBot/musicbot/bot.py", line 137, in wrapper
return await func(self, *args, **kwargs)
File "/mnt/secondary/aleana/test/MusicBot/musicbot/bot.py", line 2445, in cmd_setavatar
thing = message.attachments[0]['url']
TypeError: 'Attachment' object is not subscriptable

Once I work out the kinks with set avatar here, I'll make a PR to solve this issue.

edit: formatting is hard pepehands

[AutumnClove]

See the above PR @OzoneHelix

[OzzyHelix]

@AutumnClove thank you

[OzzyHelix]

what I discover was a partial fix it fixed links but not uploading an image

[AleanaA]

I tested your solution and got this result in VSC before even starting the bot

Undefined variable 'async_timeout'

[OzzyHelix]

its odd because when I tried your solution it was looking in init.py for it which makes no sense

[OzzyHelix]

darn github's formatting

[AleanaA]

Error given when trying my solution?

[OzzyHelix]

Unable to change avatar: module 'aiohttp' has no attribute 'ClientTimeout'

[OzzyHelix]

its really weird

[OzzyHelix]

I should probably say I'm using Pycham and not VSC

[AleanaA]

If you update your dependencies for review, you'll most likely solve that error. The current requirements.txt for d.py rewrite requires aiohttp>=3.3.0,<3.4.0 which has ClientTimeout

[OzzyHelix]

so I should add aiohttp to requirements.txt

[AleanaA]

No, d.py rewrite already requires it, and as such, doesn't need to be added to the requirements file.

[OzzyHelix]

No matching distribution found for aiohttp<3.4.0,>=3.3.0 (from -r requirements.txt)
this happens when trying to update

[AleanaA]

This is a current issue that will eventually be fixed. I've found that using Python 3.6 solves this issue, however it should be noted that 3.6 can cause issues on Windows.

[OzzyHelix]

its odd because I'm trying to update on python 3.5 but I have python3.6 and python3.5 installed on my windows machine

[OzzyHelix]

wait correction I have python 3.5.2 installed

[OzzyHelix]

ok after installing python 3.6.6 your solution works completely my solution half worked so this is much better

[OzzyHelix]

I removed python 3.5.2 and now using python 3.6.6 the setavatar command works completely

[OzzyHelix]

travis also seemed to have failed when trying to use python3.5

[AleanaA]

That's a known issue.

[OzzyHelix]

well lets hope it will be resolved in the future