Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop spamming the Steam-Servers (change Interval) #10

Closed
Pandiora opened this issue Nov 2, 2015 · 7 comments
Closed

Stop spamming the Steam-Servers (change Interval) #10

Pandiora opened this issue Nov 2, 2015 · 7 comments
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers.

Comments

@Pandiora
Copy link
Contributor

Pandiora commented Nov 2, 2015

Theres one more reason why bots can´t connect > the interval for connecting your different bots is to low. Steam completely blocks access to their servers for some time if you spam 3 logons in just 1 second. I tried to login with Steam-Client after running ASF and get an error, that my login-attempt failed. (login-credentials definitely correct)

JustArchi added a commit that referenced this issue Nov 3, 2015
@JustArchi
Copy link
Member

I released the most simple solution, we just delay creating bots to 1 bot per second.

e8335ac

Try it. I don't have enough accounts.

@JustArchi JustArchi added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. labels Nov 3, 2015
@Pandiora
Copy link
Contributor Author

Pandiora commented Nov 3, 2015

The delay is to short. I changed the delay to 5s first and was able to connect 80 bots, then I got the "Invalid Password"-Error again. Now I modified the delay to something random between 5 and 10 seconds and nearly all bots connected and started farming! I will update program.cs with a delay of 5 - 15 seconds. I think then it would be possible to connect over 200 bots. I know it will take long until all bots connected and this isn´t as fast as in the beginning, but its the best solution so far.

Edit: The delays has to be added for reconnects also. Just add this here so I won´t forget.

Pandiora added a commit to Pandiora/ArchiSteamFarm that referenced this issue Nov 3, 2015
@JustArchi
Copy link
Member

I took your idea and improved it greatly, so bots now limit steam logins also on reconnects + they're sleeping asynchronously (we should avoid Thread.Sleep() at all cost because it's blocking main thread too)

Pull my latest changes and test if all of your bots still work properly.

@JustArchi
Copy link
Member

Still need feedback ^

@Pandiora
Copy link
Contributor Author

Pandiora commented Nov 5, 2015

I would say it works now with the 5s delay but I´m getting some errors with debian(mono) after ~110 bots connected:

  • EXCEPTION: UrlToHttpResponse() The Task was canceled
  • WEB API Call timed out

There are 5 users trying to reconnect at the same time. With Windows it looks like its working, there were 188 bots connected at the same time. But ~20 bots were missing and didn´t connected for some reason. The log is gone so I can´t figure out what happened. Also there are no messages that those bots tried to reconnect, so dunno.

Maybe its better to read the delay from config? I think it would help if someone has more bots then me. Its like there is a limit per minute or hour like you said and this way everyone could use its own delay depending on how much bots he owns. A user like you with 5 bots don´t need a 5s delay.

Update: Tested it the second time now with debian and I have still the same problem. htop shows me spikes in cpu-usage - maybe my server can´t handle it. I´m having 2 cpu´s and 4 GB RAM, thought that would be enough. Curious this problem occurs again for 110 connected users. Last time when I tested with Thread.Sleep this was also a wall I hit and after I used random delays it worked. So maybe its the same problem again.

@JustArchi
Copy link
Member

For now I think that we leave 5 sec on, and make it switchable in future.

@JustArchi
Copy link
Member

Anyway, fixed for now.

@JustArchi JustArchi removed the 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. label Nov 8, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers.
Projects
None yet
Development

No branches or pull requests

2 participants