Only one of multiple accounts with passwords stored in files are able to log in

[ChlorideCull]

Checklist

• I read and understood ASF's Contributing guidelines
• I also read Setting-up and FAQ, I don't need help, this is a bug report
• I don't own more than 10 accounts in total
• I'm not using custom plugins
• This is not a question
• This is not a technical issue
• This is not ASF-ui problem

ASF version

Latest stable release

ASF variant

linux-x64

Bug description

Since updating from 5.2.4.2, only the first account with a PasswordFormat of 4 (File) successfully logs in, other accounts gets an InvalidPassword error.

Expected behavior

All accounts should be able to log in with passwords stored in files.

Actual behavior

Only the first account with passwords stored in files is able to log in.

Steps to reproduce

No response

Possible reason/solution

Only 1dcf98c has touched passwords, so it's probably the culprit.

Can you help us with this bug report?

Somehow, I can test and offer feedback, but can't code

Full log.txt recorded during reproducing the problem

You can find it here since it's too long for github: https://plumpphilomena.k8s.chcl.se/sharex/BIGBRAEBURN/2022/05/log.3.txt

Global ASF.json config file

{
  "IPCPassword": "notmyrealpassword",
  "SteamMessagePrefix": "/pre ",
  "SteamOwnerID": 0,
  "UpdateChannel": 0,
  "SteamTokenDumperPlugin": {
    "Enabled": false,
    "SecretAppIDs": [
      0
    ],
    "SecretDepotIDs": [
      0,
      1,
      2,
      3,
      4,
      5,
      6,
      7
    ],
    "SecretPackageIDs": [
      0
    ],
    "SkipAutoGrantPackages": false
  }
}

BotName.json config of all affected bot instances

// MainAccount.json
{
  "Enabled": true,
  "FarmingOrders": [
    6
  ],
  "HoursUntilCardDrops": 0,
  "OnlineStatus": 0,
  "PasswordFormat": 4,
  "RedeemingPreferences": 5,
  "SkipRefundableGames": true,
  "SteamLogin": "username",
  "SteamPassword": "../secrets/MainAccount.password",
  "SteamTradeToken": "token"
}

// SideAccountA.json
{
  "AcceptGifts": true,
  "AutoSteamSaleEvent": true,
  "BotBehaviour": 63,
  "CustomGamePlayedWhileFarming": "Idling cards",
  "Enabled": true,
  "MatchableTypes": [
    2,
    4,
    5
  ],
  "OnlineStatus": 5,
  "PasswordFormat": 4,
  "RedeemingPreferences": 1,
  "SteamLogin": "username",
  "SteamPassword": "../secrets/SideAccountA.password",
  "TradingPreferences": 23
}

// SideAccountB.json
{
  "AcceptGifts": true,
  "AutoSteamSaleEvent": true,
  "BotBehaviour": 62,
  "CompleteTypesToSend": [
    3,
    5
  ],
  "CustomGamePlayedWhileFarming": "Idling cards, ready for commands",
  "CustomGamePlayedWhileIdle": "Ready for commands",
  "Enabled": true,
  "LootableTypes": [
    1,
    3
  ],
  "OnlineStatus": 5,
  "PasswordFormat": 4,
  "RedeemingPreferences": 1,
  "SteamLogin": "username",
  "SteamPassword": "../secrets/SideAccountB.password",
  "TradingPreferences": 19,
  "TransferableTypes": [
    1,
    2,
    3,
    4,
    5,
    6,
    7,
    8,
    9,
    10,
    11,
    12,
    13,
    14
  ]
}

Additional info

No response

[JustArchi]

I'm unlikely to believe 1dcf98c is the culprit because it doesn't touch the mechanism, only situation in which ASF asks you for input, and you're not asking for input here.

Ensure that the passwords in both files are correct and also that you can log in onto those accounts yourself using provided credentials with your Steam client. ASF doesn't control whether Steam allows you to log in or not, and InvalidPassword is generic authentication failure, it doesn't include only the incorrect password itself.

Are you able to log in onto those two accounts with the same copy-pasted config structure in old ASF side-by-side? Set up older ASF, disable its update by setting UpdatePeriod to 0 and verify yourself, because I'm rather skeptical ASF update is the root cause of your problems.

[JustArchi]

Nevermind, I found the issue, good catch @ChlorideCull, it affects File and EnvironmentVariable steam password formats.

[JustArchi]

This issue should be fixed in ASF V5.2.5.6, please give it a try @ChlorideCull once it releases (should be up to an hour max from now) and let me know if it fixes your issue. If yes I'll promote it to stable ASAP.

Thanks for report 🏆

[ChlorideCull]

@JustArchi Can confirm that it fixes it!

[JustArchi]

Nice, thanks for confirmation, I've promoted that release to stable as a hotfix 🙂