Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchiSteamFarm is unable to generate Web API Keys anymore #3084

Closed
7 tasks done
nolddor opened this issue Dec 1, 2023 · 2 comments
Closed
7 tasks done

ArchiSteamFarm is unable to generate Web API Keys anymore #3084

nolddor opened this issue Dec 1, 2023 · 2 comments
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently.

Comments

@nolddor
Copy link
Contributor

nolddor commented Dec 1, 2023

Checklist

ASF version

Latest stable release

ASF variant

linux-x64

Bug description

It looks like today Valve roll out a new change so in order to create a Web API Key, a mobile confirmation is needed.
Refers to https://twitter.com/zerguet/status/1730531743575208386

Expected behavior

ArchiSteamFarm must be able to auto-generate a Web API Key when not present as it is a mandatory requirement for ASF to query some internal APIs

Actual behavior

An error is thrown on the logs:

2023-12-01 18:59:44|ArchiSteamFarm-728438|ERROR|BotName|ResolveApiKey() Received unknown value for State, please report this: NotRegisteredYet 

Steps to reproduce

  1. Navigate to https://steamcommunity.com/dev/apikey en delete any existing Web API (if any)
  2. Start up ArchiSteamFarm from scratch or do a !restart
  3. You will see the error within the logs.

Possible reason/solution

A recent change at Valve side as per https://twitter.com/zerguet/status/1730531743575208386 that requires source code rework to auto-confirm the Web API Key generation, refers to:

private async Task<bool> RegisterApiKey() {

Can you help us with this bug report?

Somehow, I can test and offer feedback, but can't code

Full log.txt recorded during reproducing the problem

N/A

Global ASF.json config file

N/A

BotName.json config of all affected bot instances

N/A

Additional info

@nolddor nolddor added 🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. labels Dec 1, 2023
@JustArchi JustArchi added 💭 Acknowledged Issues marked with this label were acknowledged, but weren't verified yet, waiting for confirmation. 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. 💭 Acknowledged Issues marked with this label were acknowledged, but weren't verified yet, waiting for confirmation. labels Dec 1, 2023
@JustArchi
Copy link
Member

Thanks for report, I've addressed this with a warning and automatic registration (if possible) 🏆

@JustArchi
Copy link
Member

JustArchi commented Dec 11, 2023

Update: follow-up on this issue includes complete API keys removal, I'm leaving this note mainly for people digging into the issue wondering about current state of API keys in ASF.

27f965d
fa74d98

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛 Bug Issues marked with this label indicate unintended program behaviour that needs correction. ✔️ Confirmed Issues marked with this label were acknowledged and confirmed by the developers. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 🟡 Medium priority Issues marked with this label have a priority, unless there is something even more important. 💥 Regression Issues marked with this label are regressions - bugs that were introduced recently.
Projects
None yet
Development

No branches or pull requests

2 participants