Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite family sharing IDs for new Steam families #3162

Closed
8 tasks done
JustArchi opened this issue Mar 18, 2024 · 0 comments
Closed
8 tasks done

Rewrite family sharing IDs for new Steam families #3162

JustArchi opened this issue Mar 18, 2024 · 0 comments
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.

Comments

@JustArchi
Copy link
Member

JustArchi commented Mar 18, 2024 •
edited
Loading

Checklist

Enhancement purpose

We need refactor in order to support https://store.steampowered.com/news/collection/steam/?emclan=103582791457287600&emgid=4149575031735702628

Solution

Wait for SteamRE/SteamKit#1342 to happen, then refactor existing GetFamilySharingSteamIDs(). We might need to union both while both systems are operative.

Why currently available solutions are not sufficient?

New family sharing steamIDs are not recognized by ASF. Not a major problem, but we should either support it or drop the feature entirely.

Can you help us with this enhancement idea?

Yes, I can code the solution myself and send a pull request

Additional info

No response
@JustArchi JustArchi added ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. and removed 👀 Evaluation Issues marked with this label are currently being evaluated if they're going to be considered. ✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. ☝️ External Issues marked with this label have external scope and typically depend on third-party projects. ⛔ On hold Issues marked with this label are blocked from being worked on, very often due to third-parties. labels Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
✨ Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🟢 Low priority Issues marked with this label are actively being worked on if nothing serious is on the list. 🙏 Wishlist Issues marked with this label are wishlisted. We'd like to make them happen but they're not crucial.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JustArchi