Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Roller Duplicates #1

Closed
MICAHANIMATRIX opened this issue Dec 11, 2020 · 2 comments
Closed

Item Roller Duplicates #1

MICAHANIMATRIX opened this issue Dec 11, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@MICAHANIMATRIX
Copy link

This is probably an issue that is already well known, but in case it isn't I thought I would make a point of posting this anyways. It's not uncommon for there to be two identical options, and during stream we actually got 3 identical options twice.
20201210171912_1

@MICAHANIMATRIX
Copy link
Author

I'm also not sure if this is intended or not, but when opening scavenger bags, chat picks all 10 items that drop, which slows down the stream significantly

@JustDerb
Copy link
Owner

So the item rolling is what the vanilla RoR2 code is doing - you can actually get "lucky" and see a multi-shop with 3 of the same item! I'll look into possibly adding a new config value to force re-rolls if this occurs (I'll be defaulting it off to keep the same rolling behavior as vanilla).

I'm also not sure if this is intended or not, but when opening scavenger bags, chat picks all 10 items that drop, which slows down the stream significantly

This was intended and can make things a bit slow (since you've effectively opened 10 "chests"). I might look into adding another option where maybe chat picks one of three choices and then you get 10x of them, or having it disabled outright.

@JustDerb JustDerb added the enhancement New feature or request label Dec 11, 2020
@JustDerb JustDerb self-assigned this Dec 11, 2020
@JustDerb JustDerb added this to the 1.0.1 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants