Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed inconsistent argument order in delete() and get() #50

Merged
merged 2 commits into from
Oct 21, 2016
Merged

fixed inconsistent argument order in delete() and get() #50

merged 2 commits into from
Oct 21, 2016

Conversation

gtchance
Copy link
Contributor

No description provided.

@gtchance
Copy link
Contributor Author

The delete and get arguments are now ordered the same the other methods.

dduan
dduan requested changes Oct 20, 2016
View reviewed changes
Copy link
Owner

@dduan dduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Would you mind adjusting orders of all of these to be consistent with JustAdaptor? Thanks for your work so far 👏

@gtchance
Copy link
Contributor Author

Done!

dduan
dduan approved these changes Oct 20, 2016
View reviewed changes
Copy link
Owner

@dduan dduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 😀

@dduan dduan merged commit 53a39d0 into dduan:master Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduan dduan dduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gtchance @dduan