Add data chunk to HTTPProgress when Type == .Download #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduan
requested changes
Oct 27, 2016
| public var percent: Float { | ||
| return Float(bytesProcessed) / Float(bytesExpectedToProcess) | ||
| } | ||
|
|
||
| init( |
There was a problem hiding this comment.
Can we pass in nil in upload, instead of adding this initializer?
There was a problem hiding this comment.
Good point. Done.
…custom initializer.
dduan
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I could tell, there was no way to access the data chunk being downloaded. This adds this data to HTTPProgress so it is accessible via the asyncProgressHandler.