Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show calendar week instead of month below each "week column" #1

Closed
frdmn opened this issue Nov 22, 2016 · 3 comments
Closed

Show calendar week instead of month below each "week column" #1

frdmn opened this issue Nov 22, 2016 · 3 comments

Comments

@frdmn
Copy link

frdmn commented Nov 22, 2016

Right now it says, "A A A A S S S S O O O O [...]"

What do you think?

@KevinGAleman
Copy link
Contributor

I like this idea, but with the approach used by Github on user profile pages, where they list the first three letters of the month next to the first full week of the month. I'll code it now and submit a PR to see if Justin agrees. :)

@JustinFincher
Copy link
Owner

@frdmn Well the widget can't afford two-digit numbers (eg "52") in such small space, so I just made it showing the first letter of the month. Surely it has some identification difficulty to know what week it exactly, but I think it's enough except June and July ("J" × 8).

@KevinGAleman I had the same idea when I am coding it, but later I found it seems unbalanced when showing in today center. The GitHub profile page has plenty free space to ease the unaligned feeling of month labels, but in a strict layout like iOS today center this feeling will pop-out and make it seems unbalanced. As for the PR, thank you for pointing out my typo (sorry for my limited English), but I will probably not merge it because of my personal view of the UX.

Thank you all for paying attention to this repo :-).

@frdmn frdmn closed this as completed Nov 24, 2016
@frdmn
Copy link
Author

frdmn commented Nov 24, 2016

Alright, thanks for letting us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants