Add icons in addition to color to indicate valid/invalid spaces #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsimmons
force-pushed
the
fix/accessible-valid-spaces
branch
from
a48c9a5
to
35f7ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2.
Here's some screenshots at my (poor) attempt at adding icons to help indicate validity of moves/spaces, using SVG pattern defs as fills instead of just colors and opacity.
It's just using an additional rect and text in the pattern as the background/fill. I'm not sure why the text is so bold, it makes it a little hard to distinguish the icons, but I'm sure there's a way to fix that. Or, could use O and X or something instead, for more control.
Bear, valid, color, with icons:
Bear, valid, greyscale, with icons:
King, invalid, color, with icons:
King, invalid, greyscale, with icons:
