Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Costchecks are not using GlobalRef #178

Closed
lkdvos opened this issue Jun 19, 2024 · 2 comments
Closed

Costchecks are not using GlobalRef #178

lkdvos opened this issue Jun 19, 2024 · 2 comments
Assignees

Comments

@lkdvos
Copy link
Collaborator

lkdvos commented Jun 19, 2024

Currently, the costcheck implementation uses literal references to TensorOperations methods, instead of GlobalRef, thus failing whenever this is not available in the scope of the macro.

It's an easy fix, just posting this issue here so I don't forget.

@lkdvos lkdvos self-assigned this Jun 19, 2024
@Jutho
Copy link
Owner

Jutho commented Jun 23, 2024

This was also silently included in #171 , so I think this can be closed.

@Jutho Jutho closed this as completed Jun 23, 2024
@lkdvos
Copy link
Collaborator Author

lkdvos commented Jun 24, 2024

If I don't forget, we should probably try to add some tests for this at some point as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants