Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add only() method for creating Key instance #76

Merged
merged 2 commits into from Nov 2, 2022

Conversation

irgaly
Copy link
Contributor

@irgaly irgaly commented Oct 31, 2022

Adds only() method to create only Key.

usage

store.openCursor(only(...)).collect {
    ...
}

Though openCursor(only(...)) is almost same as openCursor(Key(...)), It's confusing if only() method is absent.

@irgaly irgaly requested review from a team and cedrickcooke as code owners October 31, 2022 14:43
@cedrickcooke cedrickcooke added the minor Changes that should bump the MINOR version number label Nov 1, 2022
@cedrickcooke
Copy link
Collaborator

Looks like the build failure right now is just a missing comma, should be fixable with ./gradlew formatKotlin.

@irgaly
Copy link
Contributor Author

irgaly commented Nov 2, 2022

Thanks! I have commited the fix to apply formatKotlin.

@cedrickcooke cedrickcooke merged commit 3283d73 into JuulLabs:main Nov 2, 2022
@irgaly irgaly deleted the add_only branch November 3, 2022 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Changes that should bump the MINOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants