Return impl iterator from permutate methods #19
Conversation
…bject Also remove many of the intermediate vecs used in the various methods. I don't know if this is any faster but it feels more idiomatic, and should reduce memory usage when scanning lots of domains, since intermediate allocations should be reduced. This is obviously a breaking change since it changes the public API considerably.
|
First of all, thanks a bunch for the PR @sd2k -- it's definitely very welcome! I don't have particular objections to any of these, but I'll go through them slowly before I merge. :-) Out of curiosity, may I ask what your use-case is? If you prefer to keep it anonymised, you can just reach out to me on twitter (same handle). |
Cool, glad to hear it! Let me know if you have any concerns. One thing to note would be that returning
Nothing too exciting really; at $WORK we're looking into ways to investigate lots of domains and I thought it would be fun to try it in Rust instead, but ideally with as low a footprint as possible 🙂 |
As it is right now, it improves the interface and implementation drastically, so I am going to roll with it for the time being and push out a
I'm glad to hear that, I hope it works out! |
|
|
||
| Domain::filter_domains(Box::new(result.into_iter())) | ||
| pub fn replacement(&self) -> impl Iterator<Item = String> + '_ { | ||
| Self::filter_domains( |
There was a problem hiding this comment.
@sd2k is there a particular reason you opted for Self::filter_domains here or?
There was a problem hiding this comment.
Ah, not here specifically, no. Usually I would use Self::filter_domains everywhere (I think that's recommended by clippy sometimes? perhaps on a pedantic link), perhaps in case the struct name ever changes - I can't remember why I started tbh!
|
Version has been bumped. You should be able to pull |
|
Awesome, thanks @JuxhinDB! :) |
Hi!
Not sure if you'd be interested in this change but it fit my use case slightly better and thought you may find it useful - feel free to close this if not.
It removes the
Boxing and fallibility on all the various permutation methods ofDomainto simplify the API slightly and (hopefully) improve memory usage, since there are no internal vecs, just iterators.I think some of these methods may actually be slightly slower than before, although I'm not sure how, and the difference is a few microseconds here and there. I have a separate branch with benchmarks which I'll push so you can use them and see for yourself if you like.