Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for global (page-level) configuration options #7

Open
6 tasks
KCarlile opened this issue May 19, 2024 · 0 comments
Open
6 tasks

Allow for global (page-level) configuration options #7

KCarlile opened this issue May 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@KCarlile
Copy link
Owner

KCarlile commented May 19, 2024

Background

End-users may wish to have some control over the display of the diagrams, such as flipping all on a page to left-handed diagrams (see #5). This should be exposed via an optional page configuration block with buttons.

Acceptance Criteria

Approach

  • Consider how the canvas is rendered via JS function and use that for specifying there the global controls should be assigned
  • Does this require a higher-level or global diagram object to store all the diagrams on a page? That is, instead of this:
    let gdj1 = new GuitarDiagramsJS();
    let gdj2 = new GuitarDiagramsJS();
    ...should it be more like this?
    let gdj = new GuitarDiagramsJS();
    let gdj1 = gdj.newDiagram();
    let gdj2 = gdj.newDiagram();
    • Better idea: make a GuitarDiargramsCollection object and add gdj objects to it, then have that object render the controls. This avoids the extra layer of overhead when users don't want the global options.

Notes

TBD

@KCarlile KCarlile added the enhancement New feature or request label May 19, 2024
@KCarlile KCarlile self-assigned this May 19, 2024
@KCarlile KCarlile mentioned this issue Jun 13, 2024
2 tasks
@KCarlile KCarlile removed their assignment Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant