Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tavern][API] Add 'params' to CreateJob #103

Merged
merged 1 commit into from
Feb 12, 2023
Merged

[Tavern][API] Add 'params' to CreateJob #103

merged 1 commit into from
Feb 12, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Adds parameters JSON string to jobs, and enables it to be set with parameter values when Jobs are created. When agents check in, they'll be able to run the tome with the parameters specified on the job.

@KCarretto KCarretto requested a review from hulto February 11, 2023 22:47
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hulto hulto merged commit 023a2a1 into main Feb 12, 2023
@hulto hulto deleted the create-job-params branch February 12, 2023 01:00
KCarretto added a commit that referenced this pull request Feb 1, 2024
 
added 'params' string to job (#103)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants