Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tavern][Feature] Added names for sessions, and a neat random generator #113

Merged
merged 3 commits into from
Feb 24, 2023
Merged

[Tavern][Feature] Added names for sessions, and a neat random generator #113

merged 3 commits into from
Feb 24, 2023

Conversation

KCarretto
Copy link
Collaborator

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Adds human readable names to sessions and a cool generator for them.

@hulto hulto added feature New feature or request tavern labels Feb 24, 2023
hulto
hulto approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PERFECT 💯

@hulto hulto merged commit 8475a5b into main Feb 24, 2023
@hulto hulto deleted the name-generator branch February 24, 2023 04:15
KCarretto added a commit that referenced this pull request Feb 1, 2024
@KCarretto
9960f0d 
 
[Tavern][Feature] Added names for sessions, and a neat random generator (#113)

* Added names for sessions, and a neat random generator

* removed unneeded files

* oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hulto hulto hulto approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

Assignees
No one assigned
Labels
feature New feature or request tavern
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KCarretto @hulto