Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout Eldritch actions after 10 minutes #118

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

Milkshak3s
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adds a timeout for Eldritch GitHub Actions jobs, as a mitigation for #117

Which issue(s) this PR fixes:

Mitigates #117

@Milkshak3s Milkshak3s added the bug Something isn't working label Feb 24, 2023
Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lil nervous ten min is too short but I have no evidence so let's try it!

@Milkshak3s Milkshak3s merged commit 6cb85d0 into main Feb 24, 2023
@Milkshak3s Milkshak3s deleted the Milkshak3s-eldritch-actions-timeout-10m branch February 24, 2023 17:38
@Milkshak3s
Copy link
Collaborator Author

@hulto I believe it's per OS, and max time looks like 6 minutes per OS? We can always bump it in the same PR it causes an issue in

KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Timeout Eldritch actions after 10 minutes (#118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants