Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tempfile for Eldritch Tests #12

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Use tempfile for Eldritch Tests #12

merged 1 commit into from
Mar 6, 2022

Conversation

Cictrone
Copy link
Collaborator

@Cictrone Cictrone commented Mar 6, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

adds tmp files for our eldritch tests so we dont need to hassle with removing files/platform dependencies

Which issue(s) this PR fixes:

n/a

Test Output:

root ➜ .../realm/cmd/implants/eldritch (tmp_file_fix ✗) $ cargo test
   Compiling eldritch v0.1.0 (/workspaces/realm/cmd/implants/eldritch)
    Finished test [unoptimized + debuginfo] target(s) in 4.71s
     Running unittests (/workspaces/realm/cmd/implants/target/debug/deps/eldritch-909020e101a46f5d)

running 9 tests
test file::exists_impl::tests::test_exists_dir ... ok
test file::append_impl::tests::test_append_existing ... ok
test file::exists_impl::tests::test_exists_no_dir ... ok
test file::append_impl::tests::test_append_nonexisting ... ok
test file::exists_impl::tests::test_exists_file ... ok
test file::hash_impl::tests::test_hash ... ok
test file::exists_impl::tests::test_exists_no_file ... ok
test file::copy_impl::tests::test_copy ... ok
test tests::test_library_bindings ... ok

@Cictrone Cictrone requested a review from KCarretto March 6, 2022 04:28
@KCarretto KCarretto added the cleanup Code cleanup and tech debt removal label Mar 6, 2022
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Cictrone Cictrone merged commit 11fb2fa into main Mar 6, 2022
@Cictrone Cictrone deleted the tmp_file_fix branch March 6, 2022 04:33
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
moved the tests over to using a testfile library (#12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants