Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaned up complier error and test inconsistency. #125

Merged
merged 13 commits into from
Mar 17, 2023
Merged

Cleaned up complier error and test inconsistency. #125

merged 13 commits into from
Mar 17, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 1, 2023

What type of PR is this?

/kind cleanup
/kind eldritch-function
/kind failing-test
/kind regression

What this PR does / why we need it:

Cleans up compiler warnings and an inconsistency in the windows test on most windows VMs.

Which issue(s) this PR fixes:

Fixes #98

@hulto hulto added cleanup Code cleanup and tech debt removal bug Something isn't working labels Mar 1, 2023
KCarretto
KCarretto approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

implants/eldritch/src/process/list_impl.rs Outdated Show resolved Hide resolved
implants/eldritch/src/sys/dll_inject_impl.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited

Codecov Report

Merging #125 (0e0f6c4) into main (ecfbc00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files          27       27           
  Lines        1313     1313           
=======================================
  Hits          711      711           
  Misses        531      531           
  Partials       71       71

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto merged commit dd4a1c9 into main Mar 17, 2023
@hulto hulto deleted the cleanup-windows-compiler-error branch March 17, 2023 15:23
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
908e3d5 
 
Cleaned up complier error and test inconsistency. (#125)

* Cleaned up complier error and test inconsistency.

* Increase wait for DLL inject.

* Improved proc assert.

* sleep time is const.

* Unknown user is const.

* Cleanup compiler warn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KCarretto KCarretto KCarretto approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cleanup Code cleanup and tech debt removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Starlark dependencies
2 participants
@hulto @KCarretto