Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52 feature implement and document using git lfs for images other large files #126

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 1, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds git-lfs to store binary files.
https://git-lfs.com/

Large files are uploaded to github and replaced with a pointer to them.
This reduces the size of git clones and git history over time.

Especially if we check-in more images or a demo video.

Which issue(s) this PR fixes:

Fixes #52

@hulto hulto added the cleanup Code cleanup and tech debt removal label Mar 1, 2023
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #126 (2fd0e9a) into main (9406cfd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #126   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files          27       27           
  Lines        1313     1313           
=======================================
  Hits          711      711           
  Misses        531      531           
  Partials       71       71           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto merged commit ecfbc00 into main Mar 17, 2023
@hulto hulto deleted the 52-feature-implement-and-document-using-git-lfs-for-images-other-large-files branch March 17, 2023 02:39
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
52 feature implement and document using git lfs for images other large files (#126)

* Added existing files to lfs

* Add git-lfs to package install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup and tech debt removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Implement and document using git-lfs for images other large files.
2 participants