Fix async eldritch functions crashing golem/imix. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage 54.15% 54.15%
=======================================
Files 27 27
Lines 1313 1313
=======================================
Hits 711 711
Misses 531 531
Partials 71 71 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cictrone
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind eldritch-function
What this PR does / why we need it:
Async functions like download, and port_scan cause the agent to crash with an error about nested block_on runtimes.
To resolve this we've implemented new threads for each eldritch execution.
This creates a unique runtime for each allowing the eldritch function to create a tokio runtime.
Also resolves dll inject test failure by disabling defender in CI vms.