Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching for GitHub Actions CI #157

Merged
merged 11 commits into from
Mar 19, 2023
Merged

Conversation

Milkshak3s
Copy link
Collaborator

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds Docker image caching to our GHA workflows

Which issue(s) this PR fixes:

Fixes #155

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #157 (c48ad16) into main (dd4a1c9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #157   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files          27       27           
  Lines        1313     1313           
=======================================
  Hits          711      711           
  Misses        531      531           
  Partials       71       71           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Milkshak3s
Copy link
Collaborator Author

Old rust build times:
Screenshot 2023-03-16 at 3 21 53 PM

Times with this caching strategy:
Screenshot 2023-03-16 at 3 21 43 PM

@Milkshak3s
Copy link
Collaborator Author

This PR does not address tavern build times (14 minutes !), but it would probably benefit from something similar.

@Milkshak3s Milkshak3s marked this pull request as ready for review March 16, 2023 22:25
@Milkshak3s Milkshak3s changed the title [DRAFT] Implement caching for GitHub Actions CI Implement caching for GitHub Actions CI Mar 16, 2023
Comment on lines 53 to 54
toolchain: stable
default: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the toolchain in stable, @ reviewers please let me know problems

Copy link
Collaborator

@hulto hulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Idk what's going on with the tool chain.
Might be getting overridden by the local toolchain.
If so we should either remove the toolchain specification from the CI or make them match.

I'll try to switch us to stable so it doesn't matter.

@hulto hulto merged commit a015410 into main Mar 19, 2023
@hulto hulto deleted the milkshak3s-gha-cache-improvements branch March 19, 2023 04:03
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Implement caching for GitHub Actions CI (#157)

* Add docker image cache

* Use GHA cache type

* Ah, this is the release. Remove changes.

* Use rust-cache@v2

* Bump timeout to 15 minutes

* Specify Eldritch workspace for rust-cache

* Fix rust-cache 'target' artifact target

* Bump something to trigger workflow

* Fix the typo I added to trigger a workflow

* Update toolchain.

---------

Co-authored-by: Hulto <7121375+hulto@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] [ci] cache build artifacts between runs
2 participants