Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

156 feature golem add embedded files for dropper functionality #162

Merged
merged 15 commits into from
Mar 23, 2023
Merged

156 feature golem add embedded files for dropper functionality #162

merged 15 commits into from
Mar 23, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 19, 2023

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds embedded files and eldritch functions to copy and list embedded files.

Which issue(s) this PR fixes:

Fixes #156

@hulto hulto linked an issue Mar 19, 2023 that may be closed by this pull request
Add embedded files for dropper functionality #156
Closed
@codecov
Copy link

codecov bot commented Mar 19, 2023 •
edited

Codecov Report

Merging #162 (35747df) into main (c3478b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #162   +/-   ##
=======================================
  Coverage   56.17%   56.17%           
=======================================
  Files          28       28           
  Lines        1376     1376           
=======================================
  Hits          773      773           
  Misses        522      522           
  Partials       81       81

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hulto
hulto commented Mar 19, 2023
View reviewed changes
implants/eldritch/src/assets.rs Show resolved Hide resolved
implants/golem/src/main.rs Show resolved Hide resolved
@hulto
Copy link
Collaborator Author

hulto commented Mar 19, 2023

Resolves #152

KCarretto
KCarretto requested changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix unwraps, consider passing Asset to eldritch interpreter to enable us to pass downloaded files instead of just embedded files.

implants/eldritch/src/lib.rs Show resolved Hide resolved
implants/eldritch/src/assets.rs Show resolved Hide resolved
implants/eldritch/src/assets.rs Show resolved Hide resolved
implants/eldritch/src/assets.rs Show resolved Hide resolved
implants/golem/src/main.rs Show resolved Hide resolved
@hulto hulto requested a review from KCarretto March 22, 2023 22:58
KCarretto
KCarretto approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting to unblock :o

@hulto hulto merged commit 9c63e50 into main Mar 23, 2023
@hulto hulto deleted the 156-feature-golem-add-embedded-files-for-dropper-functionality branch March 23, 2023 01:38
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
089fda8 
 
156 feature golem add embedded files for dropper functionality (#162)

* Assets compiled in.

* Pivot lib loading and added test for regression.

* eldritch assets.list function

* eldritch assets.copy function

* Consolidated extraneous test files.

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KCarretto KCarretto KCarretto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add embedded files for dropper functionality
2 participants
@hulto @KCarretto