182 eldritch sleep blocks imix agent #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 72.16% 72.75% +0.58%
==========================================
Files 83 83
Lines 4646 4695 +49
==========================================
+ Hits 3353 3416 +63
+ Misses 1208 1194 -14
Partials 85 85
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cictrone
approved these changes
Jun 13, 2023
hulto
added a commit
that referenced
this pull request
Jun 16, 2023
* Couple tests. * Resolve async errors.
Cictrone
added a commit
that referenced
this pull request
Jun 16, 2023
* sysshell now return dict with stdout stderr status * Expanded sys exec output. * Update tests.yml (#207) * Update tests.yml needed * Update tests.yml ugg windows * Update tests.yml fml * 182 eldritch sleep blocks imix agent (#208) * Couple tests. * Resolve async errors. * 193 resolve docs issues (#195) * Updated docs. * Added golem to toc. * Fix typo start to sort by name. * Add assets docs. * Unified wording. * Clean up spelling. * Update tests. * Removed double defined test. --------- Co-authored-by: Nicholas O'Brien <ndo9903@rit.edu>
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
194 expand shell command to return exit code and stderr (#209) * sysshell now return dict with stdout stderr status * Expanded sys exec output. * Update tests.yml (#207) * Update tests.yml needed * Update tests.yml ugg windows * Update tests.yml fml * 182 eldritch sleep blocks imix agent (#208) * Couple tests. * Resolve async errors. * 193 resolve docs issues (#195) * Updated docs. * Added golem to toc. * Fix typo start to sort by name. * Add assets docs. * Unified wording. * Clean up spelling. * Update tests. * Removed double defined test. --------- Co-authored-by: Nicholas O'Brien <ndo9903@rit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
PR improves the way imix and handles async connections tasks will no longer block the main thread or each other.
Which issue(s) this PR fixes:
Fixes #182