Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

211 implement pkgtavern in imix #213

Merged
merged 11 commits into from
Jun 16, 2023
Merged

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jun 14, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR replaces the statically set graphql.rs file with a code generated pkg/tavern.
This should help keep the server and agent spec in line.

Which issue(s) this PR fixes:

Fixes #211

@hulto hulto added the imix label Jun 14, 2023
@hulto hulto linked an issue Jun 14, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #213 (8354187) into main (24b3700) will decrease coverage by 0.34%.
The diff coverage is 93.03%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   72.75%   72.42%   -0.34%     
==========================================
  Files          83       82       -1     
  Lines        4695     4617      -78     
==========================================
- Hits         3416     3344      -72     
+ Misses       1194     1188       -6     
  Partials       85       85              
Impacted Files Coverage Δ
implants/imix/src/lib.rs 33.33% <ø> (ø)
implants/pkg/tavern/src/mutations.rs 67.39% <84.61%> (+5.16%) ⬆️
implants/imix/src/main.rs 77.77% <93.66%> (+5.40%) ⬆️
implants/pkg/tavern/src/http.rs 100.00% <100.00%> (ø)
implants/pkg/tavern/src/lib.rs 88.18% <100.00%> (+0.21%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Cictrone
Copy link
Collaborator

it all broken 🥲

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype

@Cictrone Cictrone merged commit 26ff8be into main Jun 16, 2023
7 of 8 checks passed
@Cictrone Cictrone deleted the 211-implement-pkgtavern-in-imix branch June 16, 2023 01:58
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
211 implement pkgtavern in imix (#213)

* Mostly refactored missing parameters.

* Add clone and params to schema.

* Seems okay

* Boom looking good

* Debugging post results error.

* Remove debug.

* Fix httpserver matching.

* Move httptest to dev dependencies.

* Add tempfile to dev dependencies.

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pkg/tavern in Imix
2 participants