Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup implants lib and refactor dependencies #215

Merged
merged 18 commits into from
Jun 22, 2023
Merged

Cleanup implants lib and refactor dependencies #215

merged 18 commits into from
Jun 22, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jun 18, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

  • Renames implants/pkg to implants/lib
  • Moves implants/eldritch to implants/lib/eldritch
  • Updates relevant paths (e.g. in docs and code)
  • Consolidate cargo files in the workspace root

Replaces: #200

Which issue(s) this PR fixes:

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #215 (81311b8) into main (10683d4) will decrease coverage by 0.05%.
The diff coverage is 78.78%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   72.35%   72.30%   -0.05%     
==========================================
  Files          82       82              
  Lines        4666     4676      +10     
==========================================
+ Hits         3376     3381       +5     
- Misses       1205     1210       +5     
  Partials       85       85              
Impacted Files Coverage Δ
implants/lib/eldritch/src/assets.rs 51.61% <ø> (ø)
implants/lib/eldritch/src/assets/copy_impl.rs 91.30% <ø> (ø)
implants/lib/eldritch/src/assets/list_impl.rs 100.00% <ø> (ø)
implants/lib/eldritch/src/file.rs 66.33% <ø> (ø)
implants/lib/eldritch/src/file/append_impl.rs 100.00% <ø> (ø)
implants/lib/eldritch/src/file/compress_impl.rs 88.00% <ø> (ø)
implants/lib/eldritch/src/file/copy_impl.rs 100.00% <ø> (ø)
implants/lib/eldritch/src/file/download_impl.rs 98.03% <ø> (ø)
implants/lib/eldritch/src/file/exists_impl.rs 100.00% <ø> (ø)
implants/lib/eldritch/src/file/hash_impl.rs 100.00% <ø> (ø)
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto hulto changed the title Test Cleanup implants lib and refactor dependencies Jun 18, 2023
@hulto hulto mentioned this pull request Jun 18, 2023
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passed it merges

@hulto hulto merged commit 519d2fc into main Jun 22, 2023
7 of 8 checks passed
@hulto hulto deleted the implants-lib-2 branch June 22, 2023 21:41
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Cleanup implants lib and refactor dependencies (#215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants