223 implement assetsread and assetsread bytes #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulto
added
eldritch
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 74.76% 74.85% +0.08%
==========================================
Files 85 87 +2
Lines 4993 5034 +41
==========================================
+ Hits 3733 3768 +35
- Misses 1174 1180 +6
Partials 86 86
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cictrone
approved these changes
Jul 21, 2023
| }; | ||
| let mut result = String::new(); | ||
| for byte in src_file_bytes.iter() { | ||
| result.push(*byte as char); |
There was a problem hiding this comment.
this seems sooooooo slow lol, is there no faster way?
There was a problem hiding this comment.
Not sure this is faster.
little harder to read but:
let res = src_file_bytes.iter().map(|x| *x as u32).collect::<Vec<u32>>();
hulto
added a commit
that referenced
this pull request
Sep 30, 2023
* Impl, test, and docs. * read binary impl, test, and docs. * update lib test. * Fix test? * Might be faster.
KCarretto
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind eldritch-function
What this PR does / why we need it:
This PR provides the ability to read files from memory and be used by in memory processes.
Which issue(s) this PR fixes:
Fixes #223