Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

226 implement filelist method #227

Merged
merged 15 commits into from
Jul 22, 2023
Merged

226 implement filelist method #227

merged 15 commits into from
Jul 22, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jul 10, 2023

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Implements the file.list function to eldritch to enumerate files in a directory.

Which issue(s) this PR fixes:

Fixes #226

@hulto hulto linked an issue Jul 10, 2023 that may be closed by this pull request
Implement file.list method #226
Closed
@codecov
Copy link

codecov bot commented Jul 10, 2023 •
edited

Codecov Report

Merging #227 (bc522b3) into main (21563f3) will increase coverage by 0.51%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   74.24%   74.76%   +0.51%     
==========================================
  Files          84       85       +1     
  Lines        4846     4993     +147     
==========================================
+ Hits         3598     3733     +135     
- Misses       1162     1174      +12     
  Partials       86       86
Impacted Files Coverage Δ
implants/lib/eldritch/src/file.rs 64.81% <42.85%> (-1.53%) ⬇️
implants/lib/eldritch/src/file/list_impl.rs 94.28% <94.28%> (ø)
implants/lib/eldritch/src/lib.rs 92.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hulto
Copy link
Collaborator Author

hulto commented Jul 11, 2023

Codecov snitching on my debug prints :( gonna ignore.
image

Cictrone
Cictrone approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one issue around a possible panic that looks sus. ill approve to unblock but we probably want to handle it

implants/lib/eldritch/src/file.rs Outdated Show resolved Hide resolved
implants/lib/eldritch/src/file/list_impl.rs Outdated Show resolved Hide resolved
implants/lib/eldritch/src/file/list_impl.rs Show resolved Hide resolved
implants/lib/eldritch/src/file/list_impl.rs Show resolved Hide resolved
@hulto hulto merged commit bc4c246 into main Jul 22, 2023
8 checks passed
@hulto hulto deleted the 226-implement-filelist-method branch July 22, 2023 21:36
hulto added a commit that referenced this pull request Sep 30, 2023
@hulto
226 implement filelist method (#227)
08cddbe 
* Setting up

* Initial works.

* Test eldritch side.

* Docs

* Fixed display macro.
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
d6442ad 
 
226 implement filelist method (#227)

* Setting up

* Initial works.

* Test eldritch side.

* Docs

* Fixed display macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cictrone Cictrone Cictrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement file.list method
2 participants
@hulto @Cictrone