Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys get ip #228

Merged
merged 5 commits into from
Jul 22, 2023
Merged

Sys get ip #228

merged 5 commits into from
Jul 22, 2023

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Jul 12, 2023

What type of PR is this?

/kind feature
/kind eldritch-function

What this PR does / why we need it:

Adds the ability to list ip information on a system.

Which issue(s) this PR fixes:

@hulto hulto added feature New feature or request eldritch Related to the Eldritch language labels Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #228 (cc9bea4) into main (324b363) will increase coverage by 0.24%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   73.85%   74.09%   +0.24%     
==========================================
  Files          82       83       +1     
  Lines        4750     4806      +56     
==========================================
+ Hits         3508     3561      +53     
- Misses       1156     1159       +3     
  Partials       86       86              
Impacted Files Coverage Δ
implants/lib/eldritch/src/sys.rs 57.14% <50.00%> (-0.64%) ⬇️
implants/lib/eldritch/src/sys/get_ip_impl.rs 98.07% <98.07%> (ø)
implants/lib/eldritch/src/lib.rs 92.22% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick, unsure about global var being necessary but besides that lgtm

implants/lib/eldritch/src/sys/get_ip_impl.rs Show resolved Hide resolved
@hulto hulto merged commit 098afd7 into main Jul 22, 2023
8 checks passed
@hulto hulto deleted the sys-get-ip branch July 22, 2023 14:06
hulto added a commit that referenced this pull request Sep 30, 2023
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
 
Sys get ip (#228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eldritch Related to the Eldritch language feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants